Refactor compat test scripts and add Docker support for local testing#643
Open
kevinburkesegment wants to merge 2 commits intouutils:mainfrom
Open
Refactor compat test scripts and add Docker support for local testing#643kevinburkesegment wants to merge 2 commits intouutils:mainfrom
kevinburkesegment wants to merge 2 commits intouutils:mainfrom
Conversation
Extract shared logic (build_rust, check_total, print_summary, generate_result_json) into util/common.sh. Make test directories configurable via GNU_DIR/BFS_DIR env vars so scripts work in both CI and local/Docker environments. Add Dockerfile.compat and util/docker-compat.sh for running the full compat suites locally. Simplify the CI workflow: remove empty "Extract testing info" step, hoist CARGO_INCREMENTAL=0 to workflow-level env, drop ||: that masked script errors, pass explicit GNU_DIR/BFS_DIR, and remove redundant artifact download-and-compare steps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The %A+ format uses chrono's %.f which trims trailing zeros from
fractional seconds. On Windows (100ns resolution) this produces
fewer digits than on Linux (nanosecond resolution), causing the
regex to fail intermittently. Use \d+0 instead of \d{9}0.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| with: | ||
| name: gnu-result | ||
| path: gnu-result.json | ||
| - name: Download artifacts (gnu-result and gnu-test-report) |
Author
There was a problem hiding this comment.
NOTE: The previous download-and-compare steps downloaded artifacts from
the current run (${{ github.run_id }}), then compared them against
the same logs already on disk -- producing "PASS +0 / FAIL +0" every
time (confirmed in upstream CI logs). To do actual regression detection,
this would need to download artifacts from the main branch's latest
run (e.g. via dawidd6/action-download-artifact). The artifact uploads
above are preserved for the upload-annotations job.
kevinburkesegment
force-pushed
the
refactor-compat-scripts
branch
from
9c4bad1 to
7761a3d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 31 31
Lines 6203 6203
Branches 328 328
=======================================
Hits 5692 5692
Misses 390 390
Partials 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Commit 7761a3d has GNU testsuite comparison: |
1 similar comment
|
Commit 7761a3d has GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract shared logic (build_rust, check_total, print_summary,
generate_result_json) into util/common.sh. Make test directories
configurable via GNU_DIR/BFS_DIR env vars so scripts work in both
CI and local/Docker environments. Add Dockerfile.compat and
util/docker-compat.sh for running the full compat suites locally.
Simplify the CI workflow: remove empty "Extract testing info" step,
hoist CARGO_INCREMENTAL=0 to workflow-level env, drop ||: that masked
script errors, pass explicit GNU_DIR/BFS_DIR, and remove redundant
artifact download-and-compare steps.